Fix lab format-strings #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "hints:" (without the field name, it has no contents). Remove an example of a password in source code. That is a vulnerability all by itself, we do NOT want to show how to write *vulnerable* code. Signed-off-by: David A. Wheeler <[email protected]>
We don't need to create lots of code, and in fact, it's often better to switch to a constant string if we can. Let's show doing that, instead of delving into complications that are often unnecessary. Signed-off-by: David A. Wheeler <[email protected]>
|
jasinner - thank you for your earlier work! I think it'd be better if we simplified the actual lab, so we just switch to constant strings. We don't need to focus on how to attack the wrong code in the lab itself. I changed it to merely hint at an attack, and checked in full Python source code that demonstrates the details of the attack for those who want to verify it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "hints:" (without the field name, it has no contents).
Remove an example of a password in source code.
That is a vulnerability all by itself, we do NOT want to show how to write vulnerable code.