Skip to content

Discourage use of sanitizers for SUID binaries #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Discourage use of sanitizers for SUID binaries #670

merged 1 commit into from
Oct 17, 2024

Conversation

thomasnyman
Copy link
Contributor

Fixes #661

@thomasnyman thomasnyman mentioned this pull request Oct 17, 2024
Closed
thesamesam
thesamesam approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md Outdated
Sanitizers should not be used for hardening in production environments, particularly for Set User ID (SUID) binaries, as they expose operational parameters via environmental variables which can be manipulated to clobber root-owned files and privilege escalation[^Nagy2016].
[^Nagy2016]: Nagy , Szabolcs, [Address Sanitizer local root](https://www.openwall.com/lists/oss-security/2016/02/17/9), Openwall mailing list, 2026-02-16.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[^Nagy2016]: Nagy , Szabolcs, [Address Sanitizer local root](https://www.openwall.com/lists/oss-security/2016/02/17/9), Openwall mailing list, 2026-02-16.
[^Nagy2016]: Nagy , Szabolcs, [Address Sanitizer local root](https://www.openwall.com/lists/oss-security/2016/02/17/9), Openwall mailing list, 2016-02-16.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch! Fixed in 91080eb.

@thomasnyman thomasnyman force-pushed the discourage-sanitizers-for-suid-binaries branch from 790b51c to 91080eb Compare October 17, 2024 12:06
@thomasnyman thomasnyman merged commit 47834d1 into main Oct 17, 2024
5 checks passed
@thomasnyman thomasnyman deleted the discourage-sanitizers-for-suid-binaries branch October 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thesamesam thesamesam thesamesam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Product: Compiler Hardening Guide

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sanitizers need a bigger caveat with suid binaries at least

2 participants

@thomasnyman @thesamesam