Skip to content

Conversation

@david-a-wheeler
Copy link
Contributor

No description provided.

<td>“^” or “\A”
</td>
<td>“\z”; “$” works but some documents conflict
<td>“\z”; [“$” works but some documents conflict](./Correctly-Using-Regular-Expressions-Rationale#java)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this link does not render correctly because it is within a HTML table cell. Why is this a HTML table in the first place?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-a-wheeler, I took the liberty to convert the HTML table into a markdown table so that the link actually works. Let me know if using a markdown table is controversial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a markdown file, so using markdown tables isn't controversial to me. I think earlier on we used HTML table capabilities that aren't in Markdown (even GitHub flavored markdown). If we don't need those capabilities, then that's fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. I propose to go with the markdown table then.

gkunz added 2 commits January 27, 2025 22:52
This converts the HTML table to a markdown table which allows for
including links in cell whereas this does not seem to work in HTML
tables.

Signed-off-by: Georg Kunz <[email protected]>
@gkunz gkunz merged commit 7226302 into main Jan 31, 2025
5 checks passed
@gkunz gkunz deleted the xref_java_regex branch January 31, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants