Skip to content

Conversation

s19110
Copy link
Contributor

@s19110 s19110 commented Jan 3, 2025

Adding documentation to CWE-489 as part of #531

Copy link
Contributor

@BartyBoi1128 BartyBoi1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

Copy link
Contributor

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two links are wrong and need to be changed, see suggestion.

Copy link
Contributor

@gkunz gkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, apart from Helge's comments regarding the links.

@s19110 s19110 requested a review from myteron January 10, 2025 14:08
@s19110
Copy link
Contributor Author

s19110 commented Jan 10, 2025

Thank you @myteron for catching the old links. I have commited your suggestions and just need approval from you to merge this PR.

@myteron myteron merged commit b3bb08b into ossf:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants