Skip to content

redos.html: Remove YAML #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-a-wheeler merged 1 commit into from
Jan 29, 2025
Merged

redos.html: Remove YAML #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 1 addition & 49 deletions docs/labs/redos.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<link rel="stylesheet" href="checker.css">
<script src="js-yaml.min.js"></script>
<script src="checker.js"></script>
<script src="redos.js"></script>
<link rel="license" href="https://creativecommons.org/licenses/by/4.0/">

<!-- See create_labs.md for how to create your own lab! -->
Expand All @@ -24,55 +25,6 @@
</script>


<script id="info" type="application/yaml">
---
hints:
- absent: ", $"
text: This is a parameter, it must end with a comma.
- absent: |
query \( ["'`]id["'`] \)
text: Use query() with an 'id' parameter.
- present: |
query \( ["'`]id["'`] \) [^. ]
text: After query("id") use a period to invoke a verification method.
- present: |
(islength|Islength|IsLength|ISLENGTH)
text: >
JavaScript is case-sensitive. Use isLength instead of the case you have.
- absent: isLength
text: Limit the maximum length of input strings using isLength().
- present: |
isLength \( m
text: |
You need to pass isLength() an object with the max parameter, e.g., isLength({max: VALUE}).
- absent: matches
text: Use matches().
- present: |
matches \( /[^^]
text: Match the whole string - begin the regular expression with ^
- present: |
matches \( /.*[^$]/
text: Match the whole string - end the regular expression with $
- present: |
matches \( /.*[^$]/
text: Match the whole string - end the regular expression with $
- present: |
matches \( /\^\[A-Z\]
text: That would match only letters, you need digits as well.
- present: |
matches \( /\^\[a-z\]
text: That would match only lower case letters, the format requirement is uppercase letters.
- present: |
matches \( /\^\(\[A-Z0-9\]\+\)\+\$
text: Remember to fix the regex, the outer + quantifier causes backtracking by trying to match one or more sequences of one or more uppercase alphanumeric characters.
- present: |
matches \( /\^\(\[A-Z0-9\]\+\)\$
text: Remove the grouping, you don’t need the parentheses.
- present: \[0-9[Aa]-[Zz]\]
text: It's conventional to list letters first, so use [A-Z0-9] not [0-9A-Z]

# debug: true
</script>
</head>
<body>
<!-- For GitHub Pages formatting: -->
Expand Down
75 changes: 75 additions & 0 deletions docs/labs/redos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
info =
{
hints: [
{
absent: ", $",
text: "This is a parameter, it must end with a comma."
},
{
absent: String.raw`query \( ["'${BACKQUOTE}]id["'${BACKQUOTE}] \)
`,
text: "Use query() with an 'id' parameter."
},
{
present: String.raw`query \( ["'${BACKQUOTE}]id["'${BACKQUOTE}] \) [^. ]
`,
text: "After query(\"id\") use a period to invoke a verification method."
},
{
present: "(islength|Islength|IsLength|ISLENGTH)\n",
text: "JavaScript is case-sensitive. Use isLength instead of the case you have.\n"
},
{
absent: "isLength",
text: "Limit the maximum length of input strings using isLength()."
},
{
present: String.raw`isLength \( m
`,
text: "You need to pass isLength() an object with the max parameter, e.g., isLength({max: VALUE}).\n"
},
{
absent: "matches",
text: "Use matches()."
},
{
present: String.raw`matches \( /[^^]
`,
text: "Match the whole string - begin the regular expression with ^"
},
{
present: String.raw`matches \( /.*[^$]/
`,
text: "Match the whole string - end the regular expression with $"
},
{
present: String.raw`matches \( /.*[^$]/
`,
text: "Match the whole string - end the regular expression with $"
},
{
present: String.raw`matches \( /\^\[A-Z\]
`,
text: "That would match only letters, you need digits as well."
},
{
present: String.raw`matches \( /\^\[a-z\]
`,
text: "That would match only lower case letters, the format requirement is uppercase letters."
},
{
present: String.raw`matches \( /\^\(\[A-Z0-9\]\+\)\+\$
`,
text: "Remember to fix the regex, the outer + quantifier causes backtracking by trying to match one or more sequences of one or more uppercase alphanumeric characters."
},
{
present: String.raw`matches \( /\^\(\[A-Z0-9\]\+\)\$
`,
text: "Remove the grouping, you don’t need the parentheses."
},
{
present: String.raw`\[0-9[Aa]-[Zz]\]`,
text: "It's conventional to list letters first, so use [A-Z0-9] not [0-9A-Z]"
}
]
}