Skip to content

Assert no yaml #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Assert no yaml #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da9301d
assert: Remove YAML
david-a-wheeler Jan 29, 2025
34f3a30
Improve assert.js
david-a-wheeler Jan 29, 2025
6236659
Move answers into JavaScript
david-a-wheeler Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 1 addition & 91 deletions docs/labs/assert.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,101 +7,11 @@
<link rel="stylesheet" href="checker.css">
<script src="js-yaml.min.js"></script>
<script src="checker.js"></script>
<script src="assert.js"></script>
<link rel="license" href="https://creativecommons.org/licenses/by/4.0/">

<!-- See create_labs.md for how to create your own lab! -->

<!-- Sample expected answer -->
<script id="expected0" type="plain/text">
if (bindingResult.hasErrors()) {
return "form";
}
</script>

<!-- Full pattern of correct answer -->
<script id="correct0" type="plain/text">
\s* if \( bindingResult \. hasErrors \( \) \) \{
return "form" ;
\} \s*
</script>

<script id="info" type="application/yaml">
---
hints:
- present: |
assert
text: The whole point of this exercise is to NOT use `assert`
as a way to validate input from untrusted users.
examples:
- - |
assert !bindingResult.hasErrors();
- absent: |
^\s*if
text: Begin with `if` so you can return a result if there are errors.
examples:
- - |
return "form";
- present: (bindingresult|BindingResult)
text: Java is case-sensitive. Use `bindingResult`, not
`bindingresult` nor `BindingResult`.
- present: (haserrors|HasErrors)
text: Java is case-sensitive. Use `hasErrors`, not
`haserrors` nor `HasErrors`.
# https://docs.oracle.com/javase/specs/jls/se23/html/jls-14.html#jls-14.9
- present: |
^\s*if\s*[^\(\s]
text: In Java, after the keyword `if` you must have an open left parenthesis.
Conventionally there is one space between the `if` keyword and the
open left parenthesis.
examples:
- - |
if bindingResult.hasErrors
- present: |
^\s*if\s*\(\s*\!binding
text: You have an extraneous `!` (not operator).
Use the expression if (bindingResult.hasErrors()) ...
examples:
- - |
if (!bindingResult.hasErrors())
- absent: |
^ if \( bindingResult \. hasErrors \( \) \)
text: Begin the answer with the text
`if (bindingResult.hasErrors())` so that a statement will
be executed if that condition is true.
- present: |
if \( bindingResult \. hasErrors \( \) \) [^\{\s]
text: Follow the conditional with an open brace, e.g.,
`if (bindingResult.hasErrors()) {...`.
- absent: |
return "form"
text: You need to use `return "form";` somewhere.
- present: |
return "form"
absent:
return "form" ;
text: You need to use `;` (semicolon) after `return "form"` because
in Java statements must be followed by a semicolon.
- absent: |
\} $
text: The answer needs to end with `}` (closing brace).
successes:
- - |
if ( bindingResult.hasErrors() ) {
return "form";
}
- |
if ( bindingResult . hasErrors ( ) ) { return "form" ; }
failures:
- |
if ( bindingResult . hasErrors ( ) ) { return "form" }
- |
if ( ! bindingResult . hasErrors ( ) ) { return "form" ; }
- |
if bindingResult . hasErrors ( ) { return "form" ; }
- |
if ( bindingResult . hasErrors ) { return "form" ; }
# debug: true
</script>
</head>
<body>
<!-- For GitHub Pages formatting: -->
Expand Down
83 changes: 83 additions & 0 deletions docs/labs/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
info =
{
hints: [
{
present: "assert",
text: "The whole point of this exercise is to NOT use `assert` as a way to validate input from untrusted users.",
"examples": [
[ "assert !bindingResult.hasErrors();\n" ]
]
},
{
absent: String.raw`^\s* if `,
text: "Begin with `if` so you can return a result if there are errors.",
"examples": [
[ "return \"form\";" ]
]
},
{
present: "(bindingresult|BindingResult)",
text: "Java is case-sensitive. Use `bindingResult`, not `bindingresult` nor `BindingResult`."
},
{
present: "(haserrors|HasErrors)",
text: "Java is case-sensitive. Use `hasErrors`, not `haserrors` nor `HasErrors`."
},
{
present: String.raw`^\s*if\s*[^\(\s]`,
text: "In Java, after the keyword `if` you must have an open left parenthesis. Conventionally there is one space between the `if` keyword and the open left parenthesis.",
"examples": [
[ "if bindingResult.hasErrors" ]
]
},
{
present: String.raw`^\s*if\s*\(\s*\!binding`,
text: "You have an extraneous `!` (not operator). Use the expression if (bindingResult.hasErrors()) ...",
"examples": [
[ "if (!bindingResult.hasErrors())" ]
]
},
{
absent: String.raw`^ if \( bindingResult \. hasErrors \( \) \) `,
text: "Begin the answer with the text `if (bindingResult.hasErrors())` so that a statement will be executed if that condition is true."
},
{
present: String.raw`if \( bindingResult \. hasErrors \( \) \) [^\{\s] `,
text: "Follow the conditional with an open brace, e.g., `if (bindingResult.hasErrors()) {...`."
},
{
absent: String.raw`return "form"
`,
text: "You need to use `return \"form\";` somewhere."
},
{
present: String.raw`return "form"`,
absent: String.raw`return "form" ;`,
text: "You need to use `;` (semicolon) after `return \"form\"` because in Java statements must be followed by a semicolon."
},
{
absent: String.raw`\} $`,
text: "The answer needs to end with `}` (closing brace)."
},
],
expected: [
` if (bindingResult.hasErrors()) {
return "form";
}`
],
correct: [
String.raw`\s* if \( bindingResult \. hasErrors \( \) \) \{
return "form" ;
\} \s*`,
],
successes: [
[ "if ( bindingResult.hasErrors() ) {\n return \"form\";\n}\n" ],
[ "if ( bindingResult . hasErrors ( ) ) { return \"form\" ; }\n" ],
],
failures: [
[ "if ( bindingResult . hasErrors ( ) ) { return \"form\" }\n" ],
[ "if ( ! bindingResult . hasErrors ( ) ) { return \"form\" ; }\n" ],
[ "if bindingResult . hasErrors ( ) { return \"form\" ; }\n" ],
[ "if ( bindingResult . hasErrors ) { return \"form\" ; }\n" ],
]
}