adding CWE-459 #893
Merged
adding CWE-459 #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ewlxdnx <[email protected]>
BartKaras1128
suggested changes
May 20, 2025
s19110
suggested changes
May 22, 2025
There was a problem hiding this comment.
The code looks good. I have added some cosmetic suggestions. Apart from that, I agree with comments from @BartKaras1128.
Since I can't push change for pull requests of other contributors and didn't want to spam suggestions, I wanted to point out that the names of the modules, methods, etc. should be surrounded by backticks. That is the case in the internal confluence page but here these elements lack them.
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: dwiley258 <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: dwiley258 <[email protected]>
|
I've added the suggested changes to the review |
s19110
suggested changes
Jun 3, 2025
docs/Secure-Coding-Guide-for-Python/CWE-664/CWE-459/compliant01.py
Outdated
Show resolved
Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-664/CWE-459/noncompliant01.py
Outdated
Show resolved
Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-664/CWE-459/noncompliant02.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: dwiley258 <[email protected]>
…1.py Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: dwiley258 <[email protected]>
…nt01.py Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: dwiley258 <[email protected]>
…nt02.py Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: dwiley258 <[email protected]>
|
all comments have been addressed |
s19110
approved these changes
Jun 12, 2025
Signed-off-by: Helge Wehder <[email protected]>
|
Approval by Hubert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.