generated from ossf/project-template
-
Notifications
You must be signed in to change notification settings - Fork 185
adding CWE-252 #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
adding CWE-252 #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: edanhub <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Hubert Daniszewski <[email protected]>
BartKaras1128
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now!
myteron
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- typo in file name on fs: noncomplaint02.py
- naming 'sanitize' and organisation 'defensive vs offensive' in first code examples could be better, suggested code on files
- escape [ ]
- some comments on wording.
docs/Secure-Coding-Guide-for-Python/CWE-703/CWE-252/noncompliant01.py
Outdated
Show resolved
Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-703/CWE-252/compliant01.py
Outdated
Show resolved
Hide resolved
s19110
commented
Jun 30, 2025
Co-authored-by: myteron <[email protected]> Signed-off-by: Hubert Daniszewski <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: Hubert Daniszewski <[email protected]>
Signed-off-by: Hubert Daniszewski <[email protected]>
Signed-off-by: Hubert Daniszewski <[email protected]>
Signed-off-by: Hubert Daniszewski <[email protected]>
Updated the prints of the second set of code examples Signed-off-by: Hubert Daniszewski <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
…nt01.py Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
…1.py Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
myteron
reviewed
Jul 1, 2025
Co-authored-by: myteron <[email protected]> Signed-off-by: Hubert Daniszewski <[email protected]>
Updated the first set of code examples. Signed-off-by: Hubert Daniszewski <[email protected]>
myteron
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the readme to add link for CWE-459 and fixed the link for pillar CWE-597