-
Notifications
You must be signed in to change notification settings - Fork 185
Add info on minimal UBSan runtime #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
UBSan can be used in production environment if special minimal runtime is used. Signed-off-by: Yuri Gribov <[email protected]>
|
Maybe some preliminary info could be added before 326 is done? It's a pity to see such important feature as UBSan minimal runtime being completely missed from otherwise complete article... |
|
Thanks for this addition! I've proposed adding the Could we update this PR to refer to the |
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
…e-for-C-and-C++.md Co-authored-by: Thomas Nyman <[email protected]> Signed-off-by: Yuri Gribov <[email protected]>
…e-for-C-and-C++.md Co-authored-by: Thomas Nyman <[email protected]> Signed-off-by: Yuri Gribov <[email protected]>
Sure! So I'll wait for #933 merge and then rebase my PR on top of it and add link ? |
|
See #326 (comment) for GCC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! So I'll wait for #933 merge and then rebase my PR on top of it and add link ?
I can just rebase this while merging (after merging #933) since I don't expect it to conflict with #933. ( I realize the the Markdown linter is currently complaining about the missing span id but that'll resolve itself after rebasing on top of #933 )
Up to you if you want to address the equivalent option in GCC in this PR or do we take that separately.
That's fine too.
Done! |
|
Thanks! |
|
@yugr Thanks, from my side I am happy with the additions. I'd need to ask you to confirm the LF DCO for 5a7d111 by signing off that commit since the OpenSSF Charter requires DCOs for all inbound contributions (see https://github.com/ossf/tac/blob/main/dco.md). With that, I will put this on the agenda for the Compiler BP call scheduled for July 12th. |
…time in GCC. Signed-off-by: Yury Gribov <[email protected]>
|
lgtm 👍 This should be merged at the same time as #933 to ensure the relative links added here work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
UBSan can be used in production environment if special minimal runtime is used.