Skip to content

Conversation

@yugr
Copy link
Contributor

@yugr yugr commented Jun 22, 2025

UBSan can be used in production environment if special minimal runtime is used.

UBSan can be used in production environment if special minimal runtime is used.

Signed-off-by: Yuri Gribov <[email protected]>
@thesamesam
Copy link
Contributor

#326

@yugr
Copy link
Contributor Author

yugr commented Jun 22, 2025

#326

Maybe some preliminary info could be added before 326 is done? It's a pity to see such important feature as UBSan minimal runtime being completely missed from otherwise complete article...

@thomasnyman
Copy link
Contributor

Thanks for this addition! I've proposed adding the -fsanitize-minimal-runtime to the table in the UBSan description in #933. Together with these changes, I would propose we consider #326 addressed.

Could we update this PR to refer to the -fsanitize-minimal-runtime entry in that table via the span id from the text added to the general Sanitizer description?

yugr and others added 2 commits June 27, 2025 22:56
…e-for-C-and-C++.md

Co-authored-by: Thomas Nyman <[email protected]>
Signed-off-by: Yuri Gribov <[email protected]>
…e-for-C-and-C++.md

Co-authored-by: Thomas Nyman <[email protected]>
Signed-off-by: Yuri Gribov <[email protected]>
@yugr
Copy link
Contributor Author

yugr commented Jun 27, 2025

Could we update this PR to refer to the -fsanitize-minimal-runtime entry in that table via the span id from the text added to the general Sanitizer description?

Sure! So I'll wait for #933 merge and then rebase my PR on top of it and add link ?

@thesamesam
Copy link
Contributor

See #326 (comment) for GCC.

Copy link
Contributor

@thomasnyman thomasnyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! So I'll wait for #933 merge and then rebase my PR on top of it and add link ?

I can just rebase this while merging (after merging #933) since I don't expect it to conflict with #933. ( I realize the the Markdown linter is currently complaining about the missing span id but that'll resolve itself after rebasing on top of #933 )

Up to you if you want to address the equivalent option in GCC in this PR or do we take that separately.

@yugr
Copy link
Contributor Author

yugr commented Jun 29, 2025

Sure! So I'll wait for #933 merge and then rebase my PR on top of it and add link ?

I can just rebase this while merging (after merging #933) since I don't expect it to conflict with #933. ( I realize the the Markdown linter is currently complaining about the missing span id but that'll resolve itself after rebasing on top of #933 )

That's fine too.

Up to you if you want to address the equivalent option in GCC in this PR or do we take that separately.

Done!

@thesamesam
Copy link
Contributor

Thanks!

@thomasnyman
Copy link
Contributor

@yugr Thanks, from my side I am happy with the additions. I'd need to ask you to confirm the LF DCO for 5a7d111 by signing off that commit since the OpenSSF Charter requires DCOs for all inbound contributions (see https://github.com/ossf/tac/blob/main/dco.md). With that, I will put this on the agenda for the Compiler BP call scheduled for July 12th.

@yugr
Copy link
Contributor Author

yugr commented Jun 29, 2025

I'd need to ask you to confirm the LF DCO for 5a7d111 by signing off that commit

Great, should I just sign the commit and force push the branch ? Sorry, haven't done DCOs before.

@yugr
Copy link
Contributor Author

yugr commented Jun 30, 2025

I'd need to ask you to confirm the LF DCO for 5a7d111 by signing off that commit

Great, should I just sign the commit and force push the branch ? Sorry, haven't done DCOs before.

Ok, should be signed now.

@thomasnyman
Copy link
Contributor

lgtm 👍

This should be merged at the same time as #933 to ensure the relative links added here work.

Copy link
Contributor

@gkunz gkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomasnyman thomasnyman merged commit df7e528 into ossf:main Jul 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants