avformat/tls_gnutls: fix DTLS handshake failure in some WebRTC cases#70
Open
JackLau1222 wants to merge 1 commit intoworkflowsfrom
Open
avformat/tls_gnutls: fix DTLS handshake failure in some WebRTC cases#70JackLau1222 wants to merge 1 commit intoworkflowsfrom
JackLau1222 wants to merge 1 commit intoworkflowsfrom
Conversation
The early code may encounter handshake failure when publish WHIP to some server. See RFC 8827 section 6.5: All implementations MUST support DTLS 1.2 with the TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 cipher suite and the P-256 curve. So this patch uses the specific curve to avoid incompatibility. Signed-off-by: Aditya Banavi <adityabanavi@gmail.com>
github-actions
bot
force-pushed
the
workflows
branch
8 times, most recently
from
a4805ff to
d96cee1
Compare
github-actions
bot
force-pushed
the
workflows
branch
5 times, most recently
from
10f8b93 to
800cb64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The early code may encounter handshake failure when publish WHIP to some server.
See RFC 8827 section 6.5:
All implementations MUST support DTLS 1.2 with the TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 cipher suite and the P-256 curve.
So this patch uses the specific curve to avoid incompatibility.