Proxy: Fix memory load balancer server expiration handling#4649
Open
liukun4515 wants to merge 3 commits intoossrs:developfrom
Open
Proxy: Fix memory load balancer server expiration handling#4649liukun4515 wants to merge 3 commits intoossrs:developfrom
liukun4515 wants to merge 3 commits intoossrs:developfrom
Conversation
When origin server's UpdatedAt exceeds ServerAliveDuration (300s), Pick() now automatically selects a healthy server instead of returning the expired one. Added double-checked locking to ensure thread safety during concurrent server selection. Added unit tests to verify server expiration handling and concurrent access safety.
Author
|
@winlinvip PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical issue in memory-based load balancer where streams could not recover when origin servers become unhealthy.
Changes
MemoryLoadBalancer.Pick(): Now automatically switches to healthy servers when current server'sUpdatedAtexceedsServerAliveDuration(300s)Problem
Previously, once a stream was assigned to a server, it would remain bound to that server forever, even if the server became unhealthy (no heartbeat updates for >300s). This prevented streams from recovering when origin servers failed.
Solution
The
Pick()method now:Testing
Files Changed
proxy/internal/lb/mem.go: Added health checking and mutex-based lockingproxy/internal/lb/mem_test.go: Added 5 comprehensive test cases (286 lines)🤖 Generated with Claude Code