Skip to content

Conversation

@fraliv13
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 20, 2025 15:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the MsSql provisioner to support optional filestream files during database restore operations. The changes make the XTP (In-Memory OLTP) file movement conditional based on whether a filestream file is specified.

Key Changes:

  • Added support for optional filestream file in database restore specifications
  • Made provider names unique per database instance to avoid conflicts
  • Removed obsolete delete script logic from the restore process

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/apis/provisioning/v1alpha1/mssqlDatabaseTypes.go Added LogicalFileStreamFileName field to MsSqlDatabaseRestoreSpec struct
internal/controllers/provisioning/provisioners/pulumi/mssql_db.go Updated provider naming and made XTP file movement conditional based on filestream file presence
helm/crds/provisioning.totalsoft.ro_mssqldatabases.yaml Added CRD schema definition for the new logicalFileStreamFileName field
Comments suppressed due to low confidence (1)

internal/controllers/provisioning/provisioners/pulumi/mssql_db.go:1

  • The @XtpFilePath variable is declared but only used when LogicalFileStreamFileName is provided. This could cause confusion or potential SQL errors if the variable is referenced but not needed. Consider declaring this variable conditionally or updating the variable name to reflect it's for generic filestream files.
package pulumi

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants