status: Include deployment origin refspec as refspec in JSON output#3569
status: Include deployment origin refspec as refspec in JSON output#3569cgwalters merged 1 commit intoostreedev:mainfrom
Conversation
|
Hi @lxnay. Thanks for your PR. I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Code Review
This pull request adds the deployment's origin refspec to the JSON output of ostree admin status, which is a useful addition for consistency with the human-readable output. The implementation is clean and correct. It properly retrieves the refspec from the deployment's origin file and handles cases where the origin or refspec may not be present. The use of g_autofree ensures proper memory management. The change is straightforward and well-executed.
Given that we have the booted hash in the --json output, it would be quite useful to get the associated refspec, if available. This is present in the human readable
ostree admin statusoutput but not in the--jsonone.