Skip to content

status: Include deployment origin refspec as refspec in JSON output#3569

Merged
cgwalters merged 1 commit intoostreedev:mainfrom
lxnay:main
Feb 9, 2026
Merged

status: Include deployment origin refspec as refspec in JSON output#3569
cgwalters merged 1 commit intoostreedev:mainfrom
lxnay:main

Conversation

@lxnay
Copy link
Contributor

@lxnay lxnay commented Feb 9, 2026

Given that we have the booted hash in the --json output, it would be quite useful to get the associated refspec, if available. This is present in the human readable ostree admin status output but not in the --json one.

@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2026

Hi @lxnay. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the deployment's origin refspec to the JSON output of ostree admin status, which is a useful addition for consistency with the human-readable output. The implementation is clean and correct. It properly retrieves the refspec from the deployment's origin file and handles cases where the origin or refspec may not be present. The use of g_autofree ensures proper memory management. The change is straightforward and well-executed.

@cgwalters cgwalters merged commit dfd9a63 into ostreedev:main Feb 9, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants