chore: update type of pp as a result of b20250306.2#693
Merged
cmyui merged 1 commit intoosuAkatsuki:masterfrom Mar 6, 2025
Merged
chore: update type of pp as a result of b20250306.2#693cmyui merged 1 commit intoosuAkatsuki:masterfrom
cmyui merged 1 commit intoosuAkatsuki:masterfrom
Conversation
Contributor
Author
|
Saw the recent client changelog - https://osu.ppy.sh/home/changelog/stable40/20250306.2 Looks like its uint16 now. |
NiceAesth
approved these changes
Mar 6, 2025
Member
|
older clients should be fine with this change as well (at least up until the cap gets hit) so i don't see the need for versioning this packet |
cmyui
reviewed
Mar 6, 2025
cmyui
approved these changes
Mar 6, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Change the type of the performance in functions that create the "USER_STATS" packet
Related Issues / Projects
N/a
Checklist