Skip to content

chore: add dev container#705

Merged
NiceAesth merged 4 commits intomasterfrom
vscode-devcontainer
May 5, 2025
Merged

chore: add dev container#705
NiceAesth merged 4 commits intomasterfrom
vscode-devcontainer

Conversation

@7mochi
Copy link
Copy Markdown
Contributor

@7mochi 7mochi commented May 2, 2025

Describe your changes

Related Issues / Projects

Checklist

  • I've manually tested my code

@7mochi 7mochi marked this pull request as draft May 2, 2025 01:56
@NiceAesth
Copy link
Copy Markdown
Member

is there a reason in particular that this is drafted?

@7mochi
Copy link
Copy Markdown
Contributor Author

7mochi commented May 4, 2025

is there a reason in particular that this is drafted?

I was trying to find a way to make it work without having to run make build first

@7mochi 7mochi marked this pull request as ready for review May 4, 2025 15:27
Copy link
Copy Markdown
Member

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good starting point

@NiceAesth NiceAesth merged commit ba9d155 into master May 5, 2025
5 checks passed
@NiceAesth NiceAesth deleted the vscode-devcontainer branch May 5, 2025 14:00
TheFantasticLoki pushed a commit to kawatapw/kawata.py that referenced this pull request Jun 21, 2025
* chore: add dev container

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore: change postCreateCommand to use make dev command

* chore: fix wrong source value in mounts

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants