fix: tourney stream handling in get_allowed_client_versions#715
fix: tourney stream handling in get_allowed_client_versions#715TrueRou wants to merge 4 commits intoosuAkatsuki:masterfrom
Conversation
|
I'm pretty sure you can use tourney on cutting-edge too, no? |
After testing, sure it can. The sent "v" was like |
|
I have another related question, if osu_version.stream is OsuStream.TOURNEY and not (
user_info["priv"] & Privileges.DONATOR
and user_info["priv"] & Privileges.UNRESTRICTED
):
# trying to use tourney client with insufficient privileges.
return {
"osu_token": "no",
"response_body": app.packets.login_reply(
LoginFailureReason.AUTHENTICATION_FAILED,
),
}( bancho.py/app/api/domains/cho.py Line 725 in 7429091 shouldn't TOURNEY_MANAGER be given access to tourney client as well?
|
|
|
nevermind |
allow tourney manager login use tourney client
| osu_stream_strs.append("stable40") | ||
| osu_stream_strs.append("cuttingedge") | ||
|
|
||
| for osu_stream_str in osu_stream_strs: |
There was a problem hiding this comment.
i very much disagree with doing a request in a for loop here, why are we not just requesting OSU_API_V2_CHANGELOG_URL, iterating over the streams and getting dates from the latest_build?
There was a problem hiding this comment.
also, looking at the current response i can't seem to see anything about major versions anymore
Describe your changes
tourney client can't connect to bancho due to old clients, as https://osu.ppy.sh/api/v2/changelog?stream=tourney has an empty builds list.
in fact, tourney client use the same channel as the its base osu stream(stable).
Related Issues / Projects
Checklist