check user in a match before allowing match creation#745
Open
arily wants to merge 4 commits intoosuAkatsuki:masterfrom
Open
check user in a match before allowing match creation#745arily wants to merge 4 commits intoosuAkatsuki:masterfrom
arily wants to merge 4 commits intoosuAkatsuki:masterfrom
Conversation
arily
requested review from
7mochi,
NiceAesth,
cmyui and
infernalfire72
as code owners
cmyui
reviewed
Feb 24, 2026
cmyui
reviewed
Feb 24, 2026
cmyui
reviewed
Feb 24, 2026
Contributor
Author
pls check |
arily
force-pushed
the
fix-mp-room-creation
branch
from
828edcc to
4330f0a
Compare
NiceAesth
reviewed
Mar 19, 2026
Member
NiceAesth
left a comment
NiceAesth
left a comment
There was a problem hiding this comment.
looks sorta similar to what i ended up doing for bancho-service-rs
fine by me but CI will need to be addressed
Member
|
i was going to fix ci for you but allow edits from maintainers is disabled please run |
Co-authored-by: Josh Smith <cmyuiosu@gmail.com>
player now have 2 ways of fixing mp room: - by creating another match - by rejoining its existing match player who created more than 2 rooms at same time is untested, but due to this fix it shouldn't be possible anymore.
arily
force-pushed
the
fix-mp-room-creation
branch
from
71ff92b to
020b2c3
Compare
Contributor
Author
|
@NiceAesth done
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
check user in a match before allowing match creation
Related Issues / Projects
Checklist
(still collecting data in our prod)