Open
Conversation
Lazily serializes user_presence and user_stats packets on first access and reuses the cached bytes until invalidated. Invalidation occurs when privilege or stats data changes (priv updates, score submission, status change, full stats reload). This avoids redundant re-serialization when the same player's packets are sent to many recipients. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cmyui
force-pushed
the
perf/cached-presence-stats
branch
from
9782344 to
482ea55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_presenceanduser_statspacket serialization on eachPlayerobject, avoiding redundant re-serialization when the same player's packets are broadcast to many recipientsupdate_privs,add_privs,remove_privs), full stats reload (stats_from_sql_full), status changes, and score submissionscho.py(login handler, action change) andosu.py(score submission) to use cached packetsTest plan
python -m mypy app/)🤖 Generated with Claude Code