Use presigned url to get the public bucket url for asset files #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the S3 API doesn't have a method to get the url of objects for public buckets, but does to create a presigned url. We can't reliably construct the url from the s3 client endpoint and region as different providers have different formats for that, so this has to get the url from the S3 server somehow. Signed-off-by: Robert Detjens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the S3 API doesn't have a method to get the url of objects for public buckets, but does to create a presigned url. We can't reliably construct the url from the s3 client endpoint and region as different providers have different formats for that, so this has to get the url from the S3 server somehow.
Resolves #79.