Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lucky-paws-raise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-astro": major
---

feat! update configs
15 changes: 2 additions & 13 deletions src/a11y/configs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@ export function buildFlatConfigs(): Record<string, Linter.Config[]> {
newRules[`astro/${ruleName}`] = baseRules[ruleName]
}

return [
...flatBase,
{
plugins: { "jsx-a11y": base },
rules: newRules,
},
]
return [...flatBase, { rules: newRules }]
},
})
}
Expand All @@ -54,12 +48,7 @@ export function buildLegacyConfigs(): Record<string, Linter.Config> {
newRules[`astro/${ruleName}`] = baseRules[ruleName]
}

return {
...baseConfig,
plugins: ["jsx-a11y"],
extends: [baseExtend],
rules: newRules,
}
return { extends: [baseExtend], rules: newRules }
},
})
}
Expand Down
18 changes: 4 additions & 14 deletions src/rules/no-exports-from-components.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ export default createRule("no-exports-from-components", {
docs: {
description: "disallow value export",
category: "Possible Errors",
// TODO: Switch to recommended: true, in next major version
recommended: false,
recommended: true,
},
schema: [],
messages: {
Expand Down Expand Up @@ -50,19 +49,13 @@ export default createRule("no-exports-from-components", {
// Allow specific named exports
return
}
context.report({
node,
messageId: "disallowExport",
})
context.report({ node, messageId: "disallowExport" })
}

return {
ExportAllDeclaration(node) {
if (node.exportKind === "type") return
context.report({
node,
messageId: "disallowExport",
})
context.report({ node, messageId: "disallowExport" })
},
ExportDefaultDeclaration(node) {
if ((node.exportKind as "value" | "type") === "type") return
Expand All @@ -78,10 +71,7 @@ export default createRule("no-exports-from-components", {
// Allow specific named exports
continue
}
context.report({
node: spec,
messageId: "disallowExport",
})
context.report({ node: spec, messageId: "disallowExport" })
}
},
}
Expand Down
Loading