Skip to content

fix: ensure all custom container characters are properly handled#267

Open
andreww2012 wants to merge 1 commit intoota-meshi:mainfrom
andreww2012:fix/custom-container-characters-proper-handling
Open

fix: ensure all custom container characters are properly handled#267
andreww2012 wants to merge 1 commit intoota-meshi:mainfrom
andreww2012:fix/custom-container-characters-proper-handling

Conversation

@andreww2012
Copy link
Contributor

Resolves #266

This PR ensures all custom containers characters are internally marked as consumed within micromark so that "expected character to be consumed" assertion is not triggered when using the dev bundle.

How to test

NODE_OPTIONS='--conditions development' tests/src/language/extensions/custom-container.ts

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2026

⚠️ No Changeset found

Latest commit: dcca2d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-markdown-preferences@f0e5fc2

Published Instant Preview Packages:

View Commit

@andreww2012 andreww2012 force-pushed the fix/custom-container-characters-proper-handling branch from 52e96fc to dcca2d9 Compare March 11, 2026 16:20
Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Can you add a job to your CI workflow that tests that environment?
(Please use the latest version of node etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown custom container parsing fails with "expected character to be consumed" error from micromark if it is resolved to the dev bundle

2 participants