fix(sort-keys): fix incorrect result when moving down the block located at the file start#506
Merged
ota-meshi merged 2 commits intoota-meshi:masterfrom Dec 15, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 7a402b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
…ed at the file start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for building this useful ESLint plugin. ❤️
Issue
When a block that will be moved down due to the
sort-keysrule is located at the first line of the input, the fixed result will be incorrect.Reproduction
https://ota-meshi.github.io/eslint-plugin-yml/playground/#eJyrVkrOT0lVslJKslIwislLtFIwjMlLtlIwVqoFAG+aB7Q=
Input
Expected
Actual
While skipping the first line can make
sort-keyswork correctly, for example,…, it's still an issue when the first line matters and it has to be moved down because of the rule.