Use language config in shareable configs#543
Conversation
🦋 Changeset detectedLatest commit: 8281772 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the shareable configs from the legacy parser approach to ESLint v9's language config API, using language: "yml/yaml" instead of languageOptions: { parser: yaml-eslint-parser }.
Changes:
- Updated base config to use language config API
- Added comprehensive tests to verify the language config is correctly applied
- Added changeset documenting this as a breaking change
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/configs/flat/base.ts | Removed parser import and languageOptions, added language config field |
| tests/src/configs/base.ts | Added new test suite to verify language config usage and backward compatibility |
| .changeset/language-config-in-shareable-configs.md | Added changeset documenting the breaking change with major version bump |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Fixed linting errors in commit 8281772. Applied prettier formatting to the test file. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
✅ Use language config in shareable configs - COMPLETE
This is a breaking change to use the new ESLint v9 language config API instead of the legacy parser approach.
Changes Made:
Summary:
The shareable configs (
base,recommended,standard,prettier) now use the new ESLint v9 language config API (language: "yml/yaml") instead of the legacy parser approach (languageOptions: { parser: yaml-eslint-parser }).Breaking Change: Users of the shareable configs will now automatically get the language config applied.
All tests passing: 5484 tests ✓ (3 new tests added)
No security vulnerabilities: CodeQL scan clean ✓
Code review: All issues addressed ✓
Linting: All errors fixed ✓
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.