Skip to content

Use language config in shareable configs#543

Merged
ota-meshi merged 6 commits intomasterfrom
copilot/update-sharable-configs-language
Jan 19, 2026
Merged

Use language config in shareable configs#543
ota-meshi merged 6 commits intomasterfrom
copilot/update-sharable-configs-language

Conversation

Copy link
Contributor

Copilot AI commented Jan 19, 2026

✅ Use language config in shareable configs - COMPLETE

This is a breaking change to use the new ESLint v9 language config API instead of the legacy parser approach.

Changes Made:

  • Explore repository structure and understand the issue
  • Understand current sharable configs implementation
  • Understand language config API (YAMLLanguage class)
  • Run baseline tests - all passing (5481 tests)
  • Update base.ts config to use language config instead of parser
  • Run tests to verify changes work correctly (5481 tests still passing)
  • Create changeset file for breaking change
  • Final validation with code review and security scan
  • Add test to verify language config is used instead of parser
  • Improve test pattern matching for robustness
  • Fix linting errors

Summary:

The shareable configs (base, recommended, standard, prettier) now use the new ESLint v9 language config API (language: "yml/yaml") instead of the legacy parser approach (languageOptions: { parser: yaml-eslint-parser }).

Breaking Change: Users of the shareable configs will now automatically get the language config applied.

All tests passing: 5484 tests ✓ (3 new tests added)
No security vulnerabilities: CodeQL scan clean ✓
Code review: All issues addressed ✓
Linting: All errors fixed ✓

Original prompt

This section details on the original issue you should resolve

<issue_title>Using language config in sharable configs</issue_title>
<issue_description>I noticed that the sharable configs provided by this plugin don't use the newly added language config 😓

The plugin needs to use the language config in the sharable configs, but this is a breaking change.</issue_description>

<agent_instructions>Add a changeset file at the end of the work</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2026

🦋 Changeset detected

Latest commit: 8281772

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-yml Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI and others added 2 commits January 19, 2026 05:49
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Copilot AI changed the title [WIP] Update sharable configs to include language config Use language config in shareable configs Jan 19, 2026
Copilot AI requested a review from ota-meshi January 19, 2026 05:54
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
@ota-meshi ota-meshi requested a review from Copilot January 19, 2026 06:01
@ota-meshi ota-meshi marked this pull request as ready for review January 19, 2026 06:01
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the shareable configs from the legacy parser approach to ESLint v9's language config API, using language: "yml/yaml" instead of languageOptions: { parser: yaml-eslint-parser }.

Changes:

  • Updated base config to use language config API
  • Added comprehensive tests to verify the language config is correctly applied
  • Added changeset documenting this as a breaking change

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/configs/flat/base.ts Removed parser import and languageOptions, added language config field
tests/src/configs/base.ts Added new test suite to verify language config usage and backward compatibility
.changeset/language-config-in-shareable-configs.md Added changeset documenting the breaking change with major version bump

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linting errors

Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 19, 2026

Please fix linting errors

Fixed linting errors in commit 8281772. Applied prettier formatting to the test file.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • docs.renovatebot.com
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/eslint-plugin-yml/eslint-plugin-yml/node_modules/.bin/eslint . (dns block)
  • unpkg.com
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/eslint-plugin-yml/eslint-plugin-yml/node_modules/.bin/eslint . (dns block)
  • www.schemastore.org
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/eslint-plugin-yml/eslint-plugin-yml/node_modules/.bin/eslint . (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from ota-meshi January 19, 2026 06:15
@ota-meshi ota-meshi merged commit 12df7f4 into master Jan 19, 2026
8 checks passed
@ota-meshi ota-meshi deleted the copilot/update-sharable-configs-language branch January 19, 2026 06:23
@github-actions github-actions bot mentioned this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using language config in sharable configs

3 participants