Skip to content

Comments

feat: use @ota-meshi/ast-token-store#573

Merged
ota-meshi merged 1 commit intomasterfrom
use-token-store
Feb 17, 2026
Merged

feat: use @ota-meshi/ast-token-store#573
ota-meshi merged 1 commit intomasterfrom
use-token-store

Conversation

@ota-meshi
Copy link
Owner

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026

🦋 Changeset detected

Latest commit: 75701d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-yml Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the token store implementation by replacing the custom TokenStore class with the external @ota-meshi/ast-token-store package. This change improves maintainability by delegating token management to a dedicated library and enhances the API with additional method overloads and better type safety.

Changes:

  • Replaced custom TokenStore implementation with @ota-meshi/ast-token-store package
  • Updated YAMLSourceCode class with enhanced method signatures and comprehensive TypeScript overloads
  • Modified test suite to use a helper function for creating token stores with proper configuration

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Added @ota-meshi/ast-token-store dependency
src/language/token-store.ts Removed entire custom TokenStore implementation (506 lines deleted)
src/language/yaml-source-code.ts Integrated external TokenStore with updated imports, enhanced method overloads, and simplified isSpaceBetween implementation
tests/src/language/token-store.ts Updated tests to use createStore helper function and import TokenStore from external package
.changeset/real-fireants-beg.md Added changeset documenting the feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ota-meshi ota-meshi merged commit 099cb89 into master Feb 17, 2026
17 checks passed
@ota-meshi ota-meshi deleted the use-token-store branch February 17, 2026 12:34
@github-actions github-actions bot mentioned this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant