Conversation
🦋 Changeset detectedLatest commit: 75701d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the token store implementation by replacing the custom TokenStore class with the external @ota-meshi/ast-token-store package. This change improves maintainability by delegating token management to a dedicated library and enhances the API with additional method overloads and better type safety.
Changes:
- Replaced custom
TokenStoreimplementation with@ota-meshi/ast-token-storepackage - Updated
YAMLSourceCodeclass with enhanced method signatures and comprehensive TypeScript overloads - Modified test suite to use a helper function for creating token stores with proper configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added @ota-meshi/ast-token-store dependency |
| src/language/token-store.ts | Removed entire custom TokenStore implementation (506 lines deleted) |
| src/language/yaml-source-code.ts | Integrated external TokenStore with updated imports, enhanced method overloads, and simplified isSpaceBetween implementation |
| tests/src/language/token-store.ts | Updated tests to use createStore helper function and import TokenStore from external package |
| .changeset/real-fireants-beg.md | Added changeset documenting the feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.