Skip to content

add a shared namespace #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add a shared namespace #56

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c359107
add a shared namespace
Dec 23, 2015
13013aa
add tnpm publish config
Dec 23, 2015
b9f45b1
bump ver
Dec 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,5 +196,11 @@ module.exports = {
getNamespace : get,
createNamespace : create,
destroyNamespace : destroy,
reset : reset
reset : reset,
getSharedNamespace: function () {
if (!process.sharedNamespace) {
process.sharedNamespace = create('shared_' + Date.now() + '_' + Math.random());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of generating a random name and leaving things to chance, why not consider doing it right and implementing anonymous namespaces as I requested in #52?

}
return process.sharedNamespace;
}
};