Skip to content

fix: adjust cross-rate price feed tests to ensure fresh price round data #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
O1ahmad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: adjust cross-rate price feed tests to ensure fresh price round data #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ jobs:
- uses: go-semantic-release/action@2e9dc4247a6004f8377781bef4cb9dad273a741f # v1.24.1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
force-bump-patch-version: true # ensure patch version updates trigger releases
8 changes: 5 additions & 3 deletions test/infrastructure/CrossRatePriceFeed.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ contract CrossRatePriceFeedTest is Test {
(,,, uint256 numeratorUpdatedAt,) = usdcUsdFeed.latestRoundData();
(,,, uint256 denominatorUpdatedAt,) = ethUsdFeed.latestRoundData();

// Warp to the later of the two update times to ensure both are fresh
uint256 latestUpdate = numeratorUpdatedAt > denominatorUpdatedAt ? numeratorUpdatedAt : denominatorUpdatedAt;
vm.warp(latestUpdate);
// Warp to just before the earliest feed expiration
uint256 numeratorExpiry = numeratorUpdatedAt + USDC_USD_HEARTBEAT;
uint256 denominatorExpiry = denominatorUpdatedAt + ETH_USD_HEARTBEAT;
uint256 minExpiry = numeratorExpiry < denominatorExpiry ? numeratorExpiry : denominatorExpiry;
vm.warp(minExpiry - 1);
}

/// @notice test constructor reverts with zero numerator feed
Expand Down