Change lua_pushnumber to lua_pushinteger for non floating point values

[xmish]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Replace some lua_pushnumber with lua_pushinteger to fix display of some integer values in game.
I'm not sure if it's a valid approach and also I'm not sure about changes in:

• setField
• LuaScriptInterface::registerVariable

Issues addressed:
#4522

[ranisalt]

Sorry missclicked

[EvilHero90]

needs a rebase

[ranisalt]

@EvilHero90 we can't merge this right now because it implies dropping LuaJIT support, but we can do it for the next release cycle

[EvilHero90]

@EvilHero90 we can't merge this right now because it implies dropping LuaJIT support, but we can do it for the next release cycle

There was no intention to push this immediatly, I just want to see if this gets worked on or not

[Codinablack]

If this does get worked on, it is worth noting that "setField" uses "lua_pushNumber" and is probably actually needing to push a decimal in some places where that method is used, but also in many places it probably shouldn't. I believe that "setField" should be changed to "setIntField", "setFloatField" (yes I know it's actually a double), and "setStringField" or something along those lines, just to be on the safe side.

[Codinablack]

I ended up using a metaprogramming approach with concepts and templates to create the additional setField overloads that are needed when making this sort of change, I recommend it highly over my previous recommendation to make new methods called setIntField, ect.

[alysonjacomin]

Hi guys, this seems to have been forgotten at some point, we could do a new analysis on these changes to merge into the main-code

[ArturKnopik]

luaPlayerGetDeathPenalty is pushing player->getLostPercent() that is double but this function is not used in TFS scripts (getPlayerLossPercent and Player:getDeathPenalty() )
rebase is required
changes for the new code are also needed, currently we have 330 calls of lua_pushnumber, this PR changes 316 of them

[alysonjacomin]

@ArturKnopik Yeah, this PR was made in 2023, we have to do a new analysis to see what should be done, it is important to highlight that in the Issue topic related to this PR, Nekiro reported some risks regarding these changes

[ranisalt]

I'm gonna refresh this

[xmish]

Im about to re-check it this weekend

[MillhioreBT]

I made this change a long time ago in the TFS downgrade engine using lua5.4, and I can confirm everything is covered. We just need to fix the conflict, and it'll be ready for review/merge.