Added Loyalty System (10.74) #4636
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| void Player::setLoyaltyBonusSkill(uint8_t skill) | ||
| { | ||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same
|
|
||
| Skill Vocation::getSkillByAccumulatedTries(uint8_t skill, uint64_t tries) | ||
| { | ||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same
|
|
||
| uint64_t Vocation::getAccumulatedReqSkillTries(uint8_t skill, uint16_t level) | ||
| { | ||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same
| uint64_t Vocation::getReqSkillTries(uint8_t skill, uint16_t level) | ||
| { | ||
| if (skill > SKILL_LAST) { | ||
| if (skill < SKILL_FIRST || skill > SKILL_LAST) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same
| float ConfigManager::getLoyaltyBonus(uint16_t points) const | ||
| { | ||
| auto it = std::find_if(loyaltyBonuses.begin(), loyaltyBonuses.end(), [points](auto&& bonus) { | ||
| auto&& [minPoints, maxPoints, _] = bonus; |
Check notice
Code scanning / CodeQL
Unused local variable
| float ConfigManager::getLoyaltyBonus(uint16_t points) const | ||
| { | ||
| auto it = std::find_if(loyaltyBonuses.begin(), loyaltyBonuses.end(), [points](auto&& bonus) { | ||
| auto&& [minPoints, maxPoints, _] = bonus; |
Check notice
Code scanning / CodeQL
Unused local variable
DSpeichert
requested changes
Mar 16, 2024
ranisalt
reviewed
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed:
#3871 Version 10.74 (The Loyalty System was introduced.)