bugfix

mathias-von-ottenbreit · mathias-von-ottenbreit · commit db1f7ef15bb6 · 2024-11-13T17:56:02.000+01:00
diff --git a/cpp/APLRRegressor.h b/cpp/APLRRegressor.h
@@ -1239,10 +1239,18 @@ void APLRRegressor::execute_boosting_step(size_t boosting_step, Eigen::Index fol
         update_coefficient_steps(boosting_step);
         if (!model_has_changed_in_this_boosting_step)
         {
-            abort_boosting = true;
-            if (verbosity >= 1)
+            if (linear_effects_only_in_this_boosting_step || non_linear_effects_allowed_in_this_boosting_step)
+            {
+                find_optimal_m_and_update_model_accordingly();
+                stopped_early = true;
+            }
+            else
             {
-                std::cout << "No further reduction in training loss was possible. Terminating the boosting procedure.\n";
+                abort_boosting = true;
+                if (verbosity >= 1)
+                {
+                    std::cout << "No further reduction in training loss was possible. Terminating the boosting procedure.\n";
+                }
             }
         }
         abort_boosting_when_no_validation_error_improvement_in_the_last_early_stopping_rounds(boosting_step);
diff --git a/documentation/APLR 10.7.4.pdf b/documentation/APLR 10.7.4.pdf
diff --git a/setup.py b/setup.py
@@ -27,7 +27,7 @@
 
 setuptools.setup(
     name="aplr",
-    version="10.7.3",
+    version="10.7.4",
     description="Automatic Piecewise Linear Regression",
     ext_modules=[sfc_module],
     author="Mathias von Ottenbreit",

Original file line number	Diff line number	Diff line change
`@@ -1239,10 +1239,18 @@ void APLRRegressor::execute_boosting_step(size_t boosting_step, Eigen::Index fol`
`1239`	`1239`	`update_coefficient_steps(boosting_step);`
`1240`	`1240`	`if (!model_has_changed_in_this_boosting_step)`
`1241`	`1241`	`{`
`1242`		`- abort_boosting = true;`
`1243`		`- if (verbosity >= 1)`
	`1242`	`+ if (linear_effects_only_in_this_boosting_step \|\| non_linear_effects_allowed_in_this_boosting_step)`
	`1243`	`+ {`
	`1244`	`+ find_optimal_m_and_update_model_accordingly();`
	`1245`	`+ stopped_early = true;`
	`1246`	`+ }`
	`1247`	`+ else`
`1244`	`1248`	`{`
`1245`		`- std::cout << "No further reduction in training loss was possible. Terminating the boosting procedure.\n";`
	`1249`	`+ abort_boosting = true;`
	`1250`	`+ if (verbosity >= 1)`
	`1251`	`+ {`
	`1252`	`+ std::cout << "No further reduction in training loss was possible. Terminating the boosting procedure.\n";`
	`1253`	`+ }`
`1246`	`1254`	`}`
`1247`	`1255`	`}`
`1248`	`1256`	`abort_boosting_when_no_validation_error_improvement_in_the_last_early_stopping_rounds(boosting_step);`