Conversation
zohar7ch
reviewed
Mar 17, 2025
zohar7ch
approved these changes
Mar 17, 2025
…wexternaltraffic.Off mode & improve event messages
zohar7ch
force-pushed
the
orisho/remove_unnecessary_event_and_improve_other_events
branch
from
5eaf0fa to
5d3e98b
Compare
zohar7ch
deleted the
orisho/remove_unnecessary_event_and_improve_other_events
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an overly verbose event with reason ReasonEnforcementGloballyDisabled, reported when external traffic policy support is disabled.
The PR also fixes the formatting of the events (to start with capital case, to meed conventions).
Testing
Checklist