When creating an external traffic network policy, now only use a single existing Otterize network policy to determine the pod selector used by the external traffic network policy as all of the different pod selectors are equivalent#575
Conversation
zohar7ch
reviewed
Mar 17, 2025
zohar7ch
approved these changes
Mar 17, 2025
zohar7ch
force-pushed
the
orisho/only_create_one_netpol_when_multiple_valid_pod_selectors_exist_for_external_traffic_policy
branch
from
bfc5c9a to
161c096
Compare
zohar7ch
force-pushed
the
orisho/only_create_one_netpol_when_multiple_valid_pod_selectors_exist_for_external_traffic_policy
branch
2 times, most recently
from
4f0a8eb to
a887330
Compare
…le existing Otterize network policy to determine the pod selector used by the external traffic network policy as all of the different pod selectors are equivalent.
zohar7ch
force-pushed
the
orisho/only_create_one_netpol_when_multiple_valid_pod_selectors_exist_for_external_traffic_policy
branch
from
a887330 to
89b2f4b
Compare
zohar7ch
deleted the
orisho/only_create_one_netpol_when_multiple_valid_pod_selectors_exist_for_external_traffic_policy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does not have any behavioral affect on the intents-operator.
Before this change, when we had to create an external traffic network policy, we used to create one and modify it many times based on existing network policies selectors.
No we only choose one selector from one existing network policy, and create the network policy only once, thus reducing the number of operations we perform in the cluster.
It also makes the code more clear and easy to understand.
Testing
Checklist