Skip to content

Fix bug where reporting applied intents to the cloud could fail when using istio, due to a missing MissingSidecarAnnotation annotation#581

Merged
amitlicht merged 2 commits intomainfrom
amitlicht/fix_missing_sidecar_annotation
Mar 31, 2025
Merged

Fix bug where reporting applied intents to the cloud could fail when using istio, due to a missing MissingSidecarAnnotation annotation#581
amitlicht merged 2 commits intomainfrom
amitlicht/fix_missing_sidecar_annotation

Conversation

@amitlicht
Copy link
Copy Markdown
Contributor

@amitlicht amitlicht commented Mar 31, 2025

Description

This PR fixes a bug where, when the MissingSidecarAnnotation is for whatever reason missing on the ClientIntents, reporting the ClientIntent to Otterize cloud would fail.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

…using istio, due to a missing MissingSidecarAnnotation annotation
@amitlicht amitlicht marked this pull request as ready for review March 31, 2025 06:21
@amitlicht amitlicht requested a review from omris94 March 31, 2025 06:21
@amitlicht amitlicht merged commit ee91ac2 into main Mar 31, 2025
21 checks passed
@amitlicht amitlicht deleted the amitlicht/fix_missing_sidecar_annotation branch March 31, 2025 07:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants