Fixed bugs with creation & deletion of role assignments when using intents v1 Azure roles.#586
Merged
evyatarmeged merged 19 commits intomainfrom Apr 24, 2025
Merged
Conversation
…ith intents v1 Azure roles
… are indeed custom otterize RAs
evyatarmeged
force-pushed
the
evya/ignore_roleassignment_exists_err
branch
from
0afa5b9 to
6d700a4
Compare
evyatarmeged
commented
Apr 20, 2025
…an event on the intents if it does not
evyatarmeged
changed the title
orishoshan
reviewed
Apr 22, 2025
Collaborator
orishoshan
left a comment
orishoshan
left a comment
There was a problem hiding this comment.
See comments. And also, we need a full-flow tests, from ClientIntents to calling APIs, with both usages of the CRD (roles and actions). To be clear, it doesn't have to be a new test if the flow is already tested, but the test has to be failing on the old code and passing on the new code, and covering the scenarios that were fixed.
...ontrollers/intents_reconcilers/iam/iampolicyagents/azurepolicyagent/agent_identities_test.go
Show resolved
Hide resolved
orishoshan
reviewed
Apr 24, 2025
src/operator/controllers/intents_reconcilers/iam/iampolicyagents/azurepolicyagent/agent.go
Outdated
Show resolved
Hide resolved
…ts/azurepolicyagent/agent.go Co-authored-by: Ori Shoshan <ori@otterize.com>
orishoshan
reviewed
Apr 24, 2025
...ntrollers/intents_reconcilers/iam/iampolicyagents/azurepolicyagent/agent_customroles_test.go
Outdated
Show resolved
Hide resolved
orishoshan
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed bugs with creation & deletion of role assignments when using intents v1 Azure roles.
Slight refactoring and tweaks for how we handle roles & role assignments, especially deletion flows.
Removed
agent_periodic_test.go, since periodic cleanups were removed.