Conversation
We now use ClusterIPs and not just ClusterIP. ClusterIPs for service is there to support dual-stack networking, so we want to support this as well. In case the IP address is IPv6, the CIDR would look different.
We want to determine whether the webhook-traffic-netpol rule will allow network traffic with or without `From` section based on configuration. When adding the `From` section, it means that the policy would be more strict (Will allow traffic only from IPs recognized as control-plane addresses).
zohar7ch
force-pushed
the
zohar7ch/auto-allow-webhooks-traffic-improvments
branch
from
65d6537 to
fc051f4
Compare
zohar7ch
commented
Jun 3, 2025
omris94
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvements for allow webhook traffic feature:
Testing
Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).
Checklist