Skip to content

Log an error if pod IPs are removed from a pod, which should not happen while a pod is running #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orishoshan wants to merge 1 commit into from
Closed

Log an error if pod IPs are removed from a pod, which should not happen while a pod is running #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/mapper/pkg/kubefinder/kubefinder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ type KubeFinder struct {
client client.Client
serviceIdResolver *serviceidresolver.Resolver
seenIPsTTLCache *expirable.LRU[string, struct{}]
podToIPCache *expirable.LRU[types.NamespacedName, map[string]struct{}]
}

var (
Expand All @@ -54,6 +55,7 @@ var (
func NewKubeFinder(ctx context.Context, mgr manager.Manager) (*KubeFinder, error) {
finder := &KubeFinder{client: mgr.GetClient(), mgr: mgr, serviceIdResolver: serviceidresolver.NewResolver(mgr.GetClient())}
finder.initSeenIPsCache()
finder.podToIPCache = expirable.NewLRU[types.NamespacedName, map[string]struct{}](50000, nil, -1)
err := finder.initIndexes(ctx)
if err != nil {
return nil, errors.Wrap(err)
Expand Down Expand Up @@ -91,10 +93,28 @@ func (k *KubeFinder) initIndexes(ctx context.Context) error {
return res
}

cachedIps, found := k.podToIPCache.Get(types.NamespacedName{Name: pod.Name, Namespace: pod.Namespace})
if found && len(cachedIps) > len(pod.Status.PodIP) {
logrus.WithFields(logrus.Fields{
"podName": pod.Name,
"podNamespace": pod.Namespace,
"cachedIps": cachedIps,
"podIps": pod.Status.PodIPs,
}).Error("Assertion failed: there are more cached IPs than pod IPs, meaning pod IPs have been removed")
}

ipList := make(map[string]struct{})
for _, ip := range pod.Status.PodIPs {
k.seenIPsTTLCache.Add(ip.IP, struct{}{})
res = append(res, ip.IP)
ipList[ip.IP] = struct{}{}
}
if found {
for ip := range ipList {
cachedIps[ip] = struct{}{}
}
}
k.podToIPCache.Add(types.NamespacedName{Name: pod.Name, Namespace: pod.Namespace}, ipList)
return res
})
if err != nil {
Expand Down
Loading