Skip to content

Conversation

@zohar7ch
Copy link
Contributor

@zohar7ch zohar7ch commented May 11, 2025

Description

Add e2e test for kafka

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@zohar7ch zohar7ch force-pushed the zohar7ch/add-kafka-e2e branch 8 times, most recently from ac2514e to 32c3dea Compare May 11, 2025 13:56
@zohar7ch zohar7ch force-pushed the zohar7ch/add-kafka-e2e branch 9 times, most recently from a0a5f6c to 3bf0327 Compare May 12, 2025 07:03
@zohar7ch zohar7ch closed this May 12, 2025
@zohar7ch zohar7ch reopened this May 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
@zohar7ch zohar7ch force-pushed the zohar7ch/add-kafka-e2e branch 9 times, most recently from 734b817 to acc1ff2 Compare May 12, 2025 10:32
@zohar7ch zohar7ch force-pushed the zohar7ch/add-kafka-e2e branch 3 times, most recently from 0dc336c to 085997d Compare May 12, 2025 11:11
@zohar7ch zohar7ch requested a review from omris94 May 12, 2025 11:17
@zohar7ch zohar7ch force-pushed the zohar7ch/add-kafka-e2e branch from 085997d to cb0492c Compare May 12, 2025 11:58
zohar7ch added 3 commits May 12, 2025 16:14
The CLI does not always outputs the Kind for the intents (depends on the
order it process the intents, the network intents & Kafka's).
So in order to make the test stable for now, we will compare without the
Kind
@zohar7ch zohar7ch force-pushed the zohar7ch/add-kafka-e2e branch from cb0492c to 302a2fe Compare May 12, 2025 13:14
@zohar7ch zohar7ch closed this May 12, 2025
@zohar7ch zohar7ch reopened this May 12, 2025
@zohar7ch zohar7ch merged commit 06259b3 into main May 12, 2025
23 checks passed
@zohar7ch zohar7ch deleted the zohar7ch/add-kafka-e2e branch May 12, 2025 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants