AO3-6067 Uncategorized fandoms in collections not showing

[ReverM]

Issue

https://otwarchive.atlassian.net/browse/AO3-6067

Purpose

This makes uncategorized fandoms be listed on collection fandoms page. As a bonus, this also makes the unwrangled tags collection page show only the work in the collection. This modifies the method used to fetch the fandom (being a combination of how it used to work with the fandom_ids field, and how view works, by going through the fandom tags on the work).

Credit

Danaël / Rever ( they / he )
Danaël Villeneuve on jira

[ReverM]

I'd like to add a test to make sure that non-canonical fandoms don't get double counted. How exactly do I set up a non-canonical fandom under a canonical fandom in cucumber?

After this is done, I shall remove put this as ready for review

[ReverM]

Hmm, I seem to not be able to locally replicate the issue with the latest automated testing

[omerfaruk-pseud]

That failed after a rerun too, and we suspect it might be because of caching. Can you disable caching for that scenario (like it is done for the first scenario on line 4)

[Bilka2]

Try the the collection counts have expired step before interacting with the collections sidebar/the fandom counts instead of disabling caching like this

[ReverM]

The test still fails. It doesn't on my end which makes troubleshooting difficult. The fact it used to work and broke on an unrelated change confuses me.

[omerfaruk-pseud]

We've discussed this and decided that we can just go with a unit test instead of an integration test. Can you add one for fandoms_controller.rb on fandoms_controller_spec.rb?

[ReverM]

We've discussed this and decided that we can just go with a unit test instead of an integration test. Can you add one for fandoms_controller.rb on fandoms_controller_spec.rb?

Alrighty. The fandom counting part is not part of the fandom_controller. Would it be more appropriate to add a test to the collection_controller?

[omerfaruk-pseud]

Since this line on fandoms_controller counts the fandoms (and the collections_controller doesn't) I thought it would be fine but I don't have a strong preference really.