AO3-7240 i18n rating, warning, fandom help files #5530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
requested changes
Jan 9, 2026
Comment on lines
+11
to
+17
| def tags_fandoms | ||
| end | ||
|
|
||
| def tags_ratings | ||
| end | ||
|
|
||
| def tags_warnings |
Contributor
There was a problem hiding this comment.
thoughts about singular vs plural here, so tags_fandoms vs tags_fandom?
Contributor
Author
There was a problem hiding this comment.
i felt like plural was slightly less weird grammatically, like, "tags: fandoms"
but i guess it makes sense both ways?
Contributor
There was a problem hiding this comment.
yeah, it makes sense both ways so let's keep it like this since it's easier
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7240
Purpose
i18n for rating help, warning help and fandom help files
Credit
slavalamp