Always run CI checks with the default features #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when matrix_all_combinations is false, previously we would run all CI with the features disabled and then have 1 run for each with it enabled now, they are always enabled, and we add 1 run that disable 1 of them when matrix_all_combinations is true this doesn't change the fact that we'll test all combinations
marcospb19
force-pushed
the
main
branch
5 times, most recently
from
91103b1 to
2b9da1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when matrix_all_combinations is false, previously we would run all CI with the features disabled and then have 1 run for each with it enabled
now, they are always enabled, and we add 1 run that disable 1 of them
when matrix_all_combinations is true this doesn't change the fact that we'll test all combinations