Fix: Decompress no longer defaults to overwrite the destination directory, and deleting files inside. #900
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix issue #813 with
ouchprompting to overwrite the destination directory, in turn deleting files in the destination, despite no conflicts. This stems from a logic issue on line 324 indecompress.rs.It now runs the following checks:
output_dirdoes not exist, it's valid and will be createdoutput_direxists AND is a directory, it's valid and will be used (even if non-empty)output_direxists AND is a file, there is a conflict and will ask the user.