Open
Conversation
Contributor
Author
|
refer to toshinari123#1 |
Contributor
Author
|
according to this github will automatically make the toshinari123#1 PR to oursky main after #15 is merged |
toshinari123
force-pushed
the
refactor-cache-into-middleware
branch
from
20c4ac0 to
84d1c11
Compare
Contributor
Author
|
passed contentcache_test and cache_test |
kiootic
reviewed
Feb 20, 2024
Collaborator
kiootic
left a comment
kiootic
left a comment
There was a problem hiding this comment.
Please also rebase on main branch and cleanup the commit history.
model type ContentCache model type ContentCache (real) corrected type ContentCache write func NewContentCache write func getContent
Fix contentcache implementation
Fix basic test
Instead of storing key and value as value, use a reference-counted map of rwmutexes (it automatically deletes mutexes so no need onExit in Ristretto) Separated into getContent and setContent in order to allow getContent call without io.ReadSeeker Used generics
used context as a receiver to pass a reference of contentcache
in order to fix import cycle
in order to fix import cycle in canon.go Fix canon.go Fix handler.go and site_handler.go Fix serve.go
added debug to cache/contentcache
Refactor contentcache Refactor cache middleware
toshinari123
force-pushed
the
refactor-cache-into-middleware
branch
from
c40f090 to
e1a9b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.