Conversation
oursimon
commented
Dec 17, 2025
| return ruleset | ||
| } | ||
|
|
||
| func Test_tmp(t *testing.T) { |
oursimon
commented
Dec 17, 2025
oursimon
commented
Dec 18, 2025
| @@ -0,0 +1,94 @@ | |||
| package solve | |||
Contributor
Author
There was a problem hiding this comment.
WDYT? Are these two tests redundant?
Contributor
There was a problem hiding this comment.
I think it makes sense to keep 1 of them to just have a check that we don't mutate the ruleset when creating a solution.
boscar
approved these changes
Dec 18, 2025
| @@ -0,0 +1,94 @@ | |||
| package solve | |||
Contributor
There was a problem hiding this comment.
I think it makes sense to keep 1 of them to just have a check that we don't mutate the ruleset when creating a solution.
oursimon
force-pushed
the
feature/90/recivers-structs
branch
from
d5e8230 to
aa3c3c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the copy function for rulesets. Now the
aMatrixget deep copied to avoid unintended bugs and enable several queries with the same ruleset.How Has This Been Tested?
Please describe how this change is tested.
Checklist: