fix: correct run_time_limit default unit (seconds → minutes)#7
Open
prabindersinghh wants to merge 1 commit intoouterbounds:mainfrom
Open
fix: correct run_time_limit default unit (seconds → minutes)#7prabindersinghh wants to merge 1 commit intoouterbounds:mainfrom
prabindersinghh wants to merge 1 commit intoouterbounds:mainfrom
Conversation
SLURM interprets bare integers as minutes, not seconds. 432000 seconds (5 * 24 * 60 * 60) = 300 days in SLURM, not 5 days. Corrected to 7200 (5 * 24 * 60) = 5 days in minutes. Updated help text and comment accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect default value for
run_time_limit— was set in secondsbut SLURM interprets bare integers as minutes, resulting in a 300-day
default instead of 5 days.
Context / Motivation
run_time_limitdefault was5 * 24 * 60 * 60 = 432000with comment"Default is set to 5 days". SLURM's
--timeinterprets bare integersas minutes, so 432000 minutes = 300 days.
Ref: https://slurm.schedmd.com/sbatch.html#OPT_time
Changes Made
5 * 24 * 60 * 60(432000) to5 * 24 * 60(7200)Testing
No automated test added — this corrects a constant default value,
verified against SLURM sbatch documentation.
Manually verified: 5 * 24 * 60 = 7200 minutes = 5 days ✓
Trade-offs / Design Decisions
Single-line change. Existing users with custom
run_time_limitvaluesare unaffected — only the default changes.