fix: replace bare except with except Exception in task_finished#9
Open
prabindersinghh wants to merge 1 commit intoouterbounds:mainfrom
Open
fix: replace bare except with except Exception in task_finished#9prabindersinghh wants to merge 1 commit intoouterbounds:mainfrom
prabindersinghh wants to merge 1 commit intoouterbounds:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
except:withexcept Exception:in task_finishedcleanup block to avoid silently swallowing SystemExit and KeyboardInterrupt.
Context / Motivation
A bare
except:catches ALL exceptions including SystemExit,KeyboardInterrupt, and GeneratorExit. This means a Ctrl+C during
cleanup would be silently swallowed, making the process appear hung.
Changes Made
except:toexcept Exception:on line 209 of slurm_decorator.pyTesting
No automated test — single line change, behavior verified by code inspection.