fix: typo in error handler for install-completion#52
Open
npdgm wants to merge 1 commit intooutscale:mainfrom
Open
fix: typo in error handler for install-completion#52npdgm wants to merge 1 commit intooutscale:mainfrom
npdgm wants to merge 1 commit intooutscale:mainfrom
Conversation
Signed-off-by: Thibault VINCENT <thibault.vincent@enix.fr>
Contributor
|
Hi @npdgm I tried to reproduce the problem with Then I built and ran the container: Instead of the expected SubprocessError, I got a FileNotFoundError: [Errno 2] No such file or directory: 'ps'. So, I suggest updating the exception handling to include FileNotFoundError as well: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a Python typo in the error handler for
oks-cli install-completion.I'm running the CLI in a container and did not have the
pscommand, so the code was reached. Also confirmed bypylint -E.