Conversation
162e1f4 to
08fabc7
Compare
324d54b to
319e32d
Compare
jobs62
approved these changes
Mar 3, 2026
jobs62
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an experimental wrapper above the S3 API, with all the OOS supported calls.
An alternative implementation would be to use an interface with all supported methods and return the standard S3 client.
Returning a wrapping struct allows easier integration in octl and allows (potentially) to redefine inputs with only the supported fields or do additional validation.
The PR also updates the template in order to add a
//sdk:groupcomment to methods to allow grouping of commands in octl.Note:
//tool:comments are directive comments and do not appear in the godoc documentation.Type of Change
Please check the relevant option(s):
How Has This Been Tested?
Please describe the test strategy:
Checklist
Additional Context