Skip to content

feat: setup dark theme#35

Merged
psterpu-c merged 2 commits intooutshift-open:mainfrom
psterpu-c:feat-dark-theme
Sep 22, 2025
Merged

feat: setup dark theme#35
psterpu-c merged 2 commits intooutshift-open:mainfrom
psterpu-c:feat-dark-theme

Conversation

@psterpu-c
Copy link
Copy Markdown
Contributor

@psterpu-c psterpu-c commented Sep 22, 2025

📝 Description

  • setup dark theme variables
  • the color palette is the same for both light and dark theme
  • the theme variables naming is the same for each theme and references different colors from the shared color palette
  • the same component overrides apply for both themes, this being possible by having the same variable names for both themes

🧪 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Style/design update
  • 🔧 Build/CI update
  • ♻️ Refactoring (no functional changes)
  • 🧪 Tests only

📚 Documentation

  • Storybook story added/updated
  • Component props documented
  • Usage examples provided
  • README updated (if needed)
  • TypeScript types exported

📋 Checklist

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Code is commented where necessary
  • No console.log statements left in code
  • Build passes locally
  • Tests added for new functionality
  • Existing tests still pass
  • No TypeScript errors
  • No accessibility violations
  • PR title follows conventional commit format

🔍 Additional Notes


For Maintainers:

  • Ready for review
  • Requires design review
  • Requires accessibility review
  • Ready to merge

Signed-off-by: Paul Sterpu <psterpu@cisco.com>
@psterpu-c psterpu-c requested a review from a team September 22, 2025 05:17
Signed-off-by: Paul Sterpu <psterpu@cisco.com>
Copy link
Copy Markdown
Member

@rafaelsilva29 rafaelsilva29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psterpu-c psterpu-c merged commit 3777306 into outshift-open:main Sep 22, 2025
6 checks passed
@rafaelsilva29
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants