Skip to content

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps sigs.k8s.io/controller-runtime from 0.6.1 to 0.7.0.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.7.0

Changes since v0.6.4

⚠️ Breaking Changes

Use client.Object & client.ObjectList

A number of methods that previously took runtime.Object & internally type-asserted them to metav1.Object now take client.Object (for non-list objects) or client.ObjectList (for lists). The practical upshot of this is more type-safety and clarity around what's required for particular methods.

All concrete API types (anything that implements runtime.Object & has a metadata field) already implement client.Object or client.ObjectList, so practical impact should be limited to folks who pass around runtime.Object values instead of concrete types.

  • Introduce and use client.Object and client.ObjectList (#1195)
  • Use client.Object for event handlers (#1118)
  • Fakeclient: Allow to pass ObjectLists to constructors (#1259)
  • client.ObjectKeyFromObject now uses client.Object (#1224)
  • Handler: Remove MapObject type and use client.Object directly (#1207)
  • Use client.Object interface in envtest (#1200)

High-Impact

  • pkg/webhook/admission: upgrade v1beta1 admission types to v1 (#1284)

    Impact: construct v1 Go types instead of v1beta1. Both versions are supported on the wire.

  • Change leaderlock from ConfigMap to ConfigMapsLeasesResourceLock (#1144)

    Impact: New RBAC permissions are needed by default for leaderelection (for the coordination/v1 API). The new lock will automatically deal with existing configmap locks (e.g. during upgrades). The can be set to its previous value ("configmaps") in manager.Options.

  • Propagate context.Context throughout the codebase (#1116)

    Impact: update various methods to accept a context.Context object, which can be used to structure timeouts and stopping loops/operations in lieu of channels

  • Change default webhook port to 9443 (#1076)

    Impact: update your deployment configuration to use port 9443, or manually configure the webhook port in manager Options.

  • Remove logs from internal controller (#1096)

    Impact: automatic logs for "succesful reconcile" no longer exist (it tended to duplicate manual logs that folks had in place).

  • Remove deprecated "--master" flag (#1039)

Commits
  • f7a3dc6 Merge pull request #1293 from estroz/bugfix/webhook-admissionreview-version
  • 27ef229 pkg/webhook/admission: set GVK on AdmissionReview responses
  • 3410e75 Merge pull request #1289 from timebertt/fix/inject-manager-logger
  • b9197ef 🐛 Inject manager's logger instead of internal one
  • 43331a6 Merge pull request #1288 from vincepri/add-test-unstrucutred-list
  • 52ba546 Add test that checks List works on UnstructuredList not in Scheme
  • 758d268 Merge pull request #1284 from estroz/feature/wh-admissionreview-v1
  • 8161d1c pkg/webhook/admission: upgrade v1beta1 admission types to v1
  • f349d96 Merge pull request #1281 from vincepri/fake-client-builder
  • d915eb1 ✨ Add fake.NewClientBuilder to build new fake clients
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Dec 14, 2020
@ouzibot
Copy link

ouzibot commented Dec 14, 2020

@dependabot-preview[bot]: Invalid title for the PR, the title needs to be like:

  • refactor: this is a refactor commit => if using semantic-release will trigger a patch release
  • fix: this is a fix commit => if using semantic-release will trigger a patch release
  • feat: this is a feature commit => if using semantic-release will trigger a minor release
  • major: this is a major commit => if using semantic-release will trigger a major release
  • doc: this is a doc commit => if using semantic-release won't trigger a new release
  • build: this is a build commit => if using semantic-release will trigger a patch release
  • no-release: this is a no-release commit => won't trigger a new release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ouzibot ouzibot added the needs-retitle Indicates a PR cannot be merged because its name doesn't match the provided regular expression. label Dec 14, 2020
@dependabot-preview
Copy link
Contributor Author

👋 If you need additional help with Dependabot, please fill out GitHub's Support form and your request will be routed to the right team at GitHub.

Be sure to include the details of any troubleshooting steps you've tried so far.

@ouzibot
Copy link

ouzibot commented Dec 14, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot-preview[bot]
To complete the pull request process, please assign givanov
You can assign the PR to them by writing /assign @givanov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ouzibot ouzibot requested review from belitre and givanov December 14, 2020 09:04
@ouzibot ouzibot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 14, 2020
@ouzibot
Copy link

ouzibot commented Dec 14, 2020

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a ouzi-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ouzibot ouzibot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 14, 2020
@ouzibot
Copy link

ouzibot commented Dec 14, 2020

@dependabot-preview[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Bumps sigs.k8s.io/controller-runtime from 0.6.1 to 0.7.0.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.7.0

Changes since v0.6.4

⚠️ Breaking Changes

Use client.Object & client.ObjectList

A number of methods that previously took runtime.Object & internally type-asserted them to metav1.Object now take client.Object (for non-list objects) or client.ObjectList (for lists). The practical upshot of this is more type-safety and clarity around what's required for particular methods.

All concrete API types (anything that implements runtime.Object & has a metadata field) already implement client.Object or client.ObjectList, so practical impact should be limited to folks who pass around runtime.Object values instead of concrete types.

  • Introduce and use client.Object and client.ObjectList (#1195)
  • Use client.Object for event handlers (#1118)
  • Fakeclient: Allow to pass ObjectLists to constructors (#1259)
  • client.ObjectKeyFromObject now uses client.Object (#1224)
  • Handler: Remove MapObject type and use client.Object directly (#1207)
  • Use client.Object interface in envtest (#1200)

High-Impact

  • pkg/webhook/admission: upgrade v1beta1 admission types to v1 (#1284)

    Impact: construct v1 Go types instead of v1beta1. Both versions are supported on the wire.

  • Change leaderlock from ConfigMap to ConfigMapsLeasesResourceLock (#1144)

    Impact: New RBAC permissions are needed by default for leaderelection (for the coordination/v1 API). The new lock will automatically deal with existing configmap locks (e.g. during upgrades). The can be set to its previous value ("configmaps") in manager.Options.

  • Propagate context.Context throughout the codebase (#1116)

    Impact: update various methods to accept a context.Context object, which can be used to structure timeouts and stopping loops/operations in lieu of channels

  • Change default webhook port to 9443 (#1076)

    Impact: update your deployment configuration to use port 9443, or manually configure the webhook port in manager Options.

  • Remove logs from internal controller (#1096)

    Impact: automatic logs for "succesful reconcile" no longer exist (it tended to duplicate manual logs that folks had in place).

  • Remove deprecated "--master" flag (#1039)

Commits
  • f7a3dc6 Merge pull request #1293 from estroz/bugfix/webhook-admissionreview-version
  • 27ef229 pkg/webhook/admission: set GVK on AdmissionReview responses
  • 3410e75 Merge pull request #1289 from timebertt/fix/inject-manager-logger
  • b9197ef 🐛 Inject manager's logger instead of internal one
  • 43331a6 Merge pull request #1288 from vincepri/add-test-unstrucutred-list
  • 52ba546 Add test that checks List works on UnstructuredList not in Scheme
  • 758d268 Merge pull request #1284 from estroz/feature/wh-admissionreview-v1
  • 8161d1c pkg/webhook/admission: upgrade v1beta1 admission types to v1
  • f349d96 Merge pull request #1281 from vincepri/fake-client-builder
  • d915eb1 ✨ Add fake.NewClientBuilder to build new fake clients
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dependabot-preview
Copy link
Contributor Author

Superseded by #207.

@dependabot-preview dependabot-preview bot deleted the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.7.0 branch January 18, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-retitle Indicates a PR cannot be merged because its name doesn't match the provided regular expression. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant