node:worker_threads: improve error messages, support environmentData, emit worker event

[190n]

What does this PR do?

These are the changes from #18758 that caused regressions or needed deeper investigation to verify correctness:

• Makes the online event fire right before a Worker starts running its entrypoint instead of right after
  • reverted, since it was breaking too many other things to merge quickly + it didn't pass any more tests
• Makes MessagePort.close accept a callback (currently we just pass the callback to nextTick, instead of calling it exactly when the port is really closed)
  • reverted, so that I can focus on regressions and merge this sooner -- I will redo this on another PR
• Validates the first argument of the Worker constructor with the right error message
• Fixes the error message when passing the wrong type to receiveMessageOnPort
• Fixes the getEnvironmentData/setEnvironmentData implementation
• Mentions the type of value in the error message when a transfer list contains a duplicated value
• Stops unrefing a worker after calling terminate()
  • reverted, since it was breaking too many other things to merge quickly
• Makes terminating a worker throw the VM's termination exception (so that terminate() can even interrupt code that blocks the event loop)
  • reverted, since it was breaking too many other things to merge quickly
• Fixes exception handling in various places related to the termination exception
• Makes a Worker terminated while synchronously running its entrypoint use exit code 1
• Moves resolving the path of a Worker's entrypoint to the new thread so that errors are emitted as error events instead of thrown as exceptions
• Makes Workers that are terminated before they start running any JS use exit code 0
• Makes the threadId of a Worker that's exited -1
• Emits the worker event on the process whenever a Worker is created

How did you verify your code works?

Added newly-passing Node tests and verify existing ones

regression todolist:

• test-worker-dns-terminate windows segfault (release only)
• test-worker-ref hang on all platforms (release only)
  • worker unref'd then re-ref'd in parent will keep parent event loop alive but not process any events
• test-worker-heapdump-failure linux segfault
• test-worker-dns-terminate-during-query attempted to assign to readonly property
  • debug now hits the assertion failure from Fix UDPSocket not being closed when VM destructs #18687
• test-worker-message-port-wasm-module flaky hang (maybe same as test-worker-ref) (release only)
• worker.test.ts flaky on linux
  • maybe same hang issue
• test-worker-message-port-transfer-terminate linux segfault
• worker.test.ts flaky
• test-worker-messagechannel-sharedarraybuffer flaky

[robobun]

^{Updated 6:34 PM PT - May 8th, 2025}

❌ @190n, your commit 90f6978 has 2 failures in Build #16321:

• test/js/bun/spawn/spawn.test.ts - timeout on 🐧 3.21 aarch64
• test/js/sql/sql.test.ts - 6 failing on 🐧 24.04 x64-baseline
• test/js/sql/sql.test.ts - 6 failing on 🐧 20.04 x64-baseline
• test/js/sql/sql.test.ts - 6 failing on 🐧 24.04 x64
• test/js/sql/sql.test.ts - 6 failing on 🐧 20.04 x64

---

🧪   To try this PR locally:

bunx bun-pr 18768

That installs a local version of the PR into your bun-18768 executable, so you can run:

bun-18768 --bun

[nektro]

Suggested change

	if (isEmpty()) {
	RETURN_IF_EXCEPTION(throwScope, );
	auto is_empty = isEmpty();
	RETURN_IF_EXCEPTION(throwScope, );
	if (is_empty) {

[190n]

are you suggesting to replace if (!isEmpty()) with if (!is_empty) too? couldn't the drainMicrotasks call cause isEmpty() to change?

[nektro]

would be easier to debug if this was individual asserts for each item. also is the binding one necessary with the addition of RETURN_IF_EXCEPTION?

[190n]

would be easier to debug if this was individual asserts for each item

done

also is the binding one necessary with the addition of RETURN_IF_EXCEPTION?

yes, binding should never be null at that point, but that's why an assertion is appropriate in case i'm wrong

[190n]

Found an issue with environmentData so I need to fix that before this can merge

[nektro]

test/js/sql/sql.test.ts is failing and test/js/node/test/parallel/test-worker-message-port-receive-message.js needs an updated message but LGTM after that

[nektro]

LGTM