Merged
Conversation
Collaborator
|
Updated 4:45 PM PT - May 9th, 2025
✅ @cirospaciari, your commit d9268fe4d02f26ce8b7217aa121485a24c500d84 passed in 🧪 To try this PR locally: bunx bun-pr 19527That installs a local version of the PR into your bun-19527 --bun |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
dylan-conway
reviewed
May 9, 2025
dylan-conway
reviewed
May 9, 2025
dylan-conway
reviewed
May 9, 2025
190n
suggested changes
May 9, 2025
Co-authored-by: 190n <ben@bun.sh>
Co-authored-by: 190n <ben@bun.sh>
190n
suggested changes
May 9, 2025
Contributor
190n
left a comment
190n
left a comment
There was a problem hiding this comment.
couple more comments on node-http.test.ts, and then let's see what happens with test-http-server-keepalive-req-gc.js in CI
190n
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
Tests